[ZEPPELIN-1391][Interpreters] print error while existing registedInterpreter with the same key but different settings#1382
Closed
WeichenXu123 wants to merge 1 commit intoapache:masterfrom
Conversation
…different settings
WeichenXu123
force-pushed
the
interpreter_key_error_check
branch
from
ccfe8e0 to
4ef032e
Compare
Contributor
Author
|
cc @jongyoul thanks! |
Member
|
LGTM. Merging if there's no more discussion. |
asfgit
pushed a commit
that referenced
this pull request
Sep 10, 2016
…methods, add null check ### What is this PR for? in PR #1382, there is a small bug that `InterpreterProperty.equals` do not check `null`. jdk lib request the `null` check otherwise it has the risk causing java collections operation throw exception. so I fix it. ### What type of PR is it? Bug Fix ### Todos N/A ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1422 ### How should this be tested? existing test. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: WeichenXu <WeichenXu123@outlook.com> Closes #1421 from WeichenXu123/fix_InterpreterProperty.equals and squashes the following commits: eb8d4ee [WeichenXu] fix_InterpreterProperty.equals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
print error while existing registedInterpreter with the same key but different settings.
In order to compare the property Map in the Interpreter easily,
I override the
equalsmethod inInterpreterPropertyclass. (andhashCodeat the same time)and I fix a small error in
InterpreterProperty.toString(), its result forgot}in the end.What type of PR is it?
Improvement
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1391
How should this be tested?
Existing tests.
Screenshots (if appropriate)
Questions: